peterxcli commented on code in PR #5225:
URL: https://github.com/apache/datafusion-comet/pull/5225#discussion_r3712222941
##########
spark/src/test/spark-4.1+/org/apache/spark/sql/comet/CometDecimalArithmeticViewSuite.scala:
##########
@@ -119,4 +104,38 @@ class CometDecimalArithmeticViewSuite extends
CometTestBase {
}
}
}
+
+ test("issue #5190: recursive serialization does not duplicate decimal
CheckOverflow") {
Review Comment:
- moved to `CometDecimalPromotionSuite`.
- make ANSI also exercise for `add`, `subtract`, `multiply`, and `remainder`
- addded `promote(promote(e)) == promote(e)`
##########
spark/src/test/spark-4.1+/org/apache/spark/sql/comet/CometDecimalArithmeticViewSuite.scala:
##########
@@ -119,4 +104,38 @@ class CometDecimalArithmeticViewSuite extends
CometTestBase {
}
}
}
+
+ test("issue #5190: recursive serialization does not duplicate decimal
CheckOverflow") {
+ val left = "CAST(id AS DECIMAL(10, 0))"
+ val right = "CAST(id + 1 AS DECIMAL(10, 0))"
+ val operations: Seq[(String, Boolean, String, ExprOuterClass.Expr =>
Boolean, Boolean)] = Seq(
Review Comment:
refactored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
