adriangb commented on code in PR #23106: URL: https://github.com/apache/datafusion/pull/23106#discussion_r3714997833
########## datafusion/sqllogictest/test_files/push_down_filter_parquet.slt: ########## @@ -1050,14 +1050,14 @@ SELECT nej_build.id, nej_probe.id FROM nej_build JOIN nej_probe ON nej_build.id 11 11 NULL NULL -# No DynamicFilter predicate may appear on the probe side of a null-equal join +# The probe side now carries a DynamicFilter for a null-equal join (widened with IS NULL at runtime) query TT EXPLAIN SELECT nej_build.id, nej_probe.id FROM nej_build JOIN nej_probe ON nej_build.id IS NOT DISTINCT FROM nej_probe.id Review Comment: Can we make this an `EXPLAIN ANALYZE` or add an `EXPLAIN ANALYZE` so we can see the final shape of the dynamic filter? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
