zhuqi-lucas commented on PR #24074: URL: https://github.com/apache/datafusion/pull/24074#issuecomment-5190789584
Thanks for the review @alamb — really appreciate the API-design and naming suggestions, they made this a much cleaner change. Latest push (`92b7e6917`) addresses everything: - Introduced `PruningPredicateBuilder` (`.with_file_schema` / `.with_error_counter` / `.with_max_in_list_size` / `.build` + `.try_build`), replacing the standalone `_with_max_in_list_size` function variants. - Renamed the config option `pruning_max_in_list_size` → `max_in_list_size` (matches `max_predicate_cache_size` style) and the const `MAX_LIST_VALUE_SIZE_REWRITE` → `MAX_IN_LIST_SIZE` so the field and const shapes line up. - Accepted the config-doc rewrite verbatim (fixed a small `of / of` duplication too). - Cleaned up the unused `build_pruning_predicate` import that Copilot flagged. - Added a `PruningPredicateBuilder`-facing unit test to lock end-to-end plumbing of `max_in_list_size` (default → `true`, raised cap → real per-value stats predicate). Regenerated `configs.md` + `information_schema.slt` to match the new key + doc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
