andygrove commented on code in PR #5275:
URL: https://github.com/apache/datafusion-comet/pull/5275#discussion_r3722706574
##########
native/core/src/lib.rs:
##########
@@ -142,7 +142,7 @@ const LOG_PATTERN: &str = "{d(%y/%m/%d %H:%M:%S)} {l} {f}:
{m}{n}";
/// * `1` (true) if the feature is enabled
/// * `0` (false) if the feature is disabled or unknown
#[no_mangle]
-pub extern "system" fn Java_org_apache_comet_NativeBase_isFeatureEnabled(
Review Comment:
Why does the function need to be renamed? It seems redundant to have
`native` in the name twice?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
