andygrove commented on code in PR #5275:
URL: https://github.com/apache/datafusion-comet/pull/5275#discussion_r3724487266
##########
spark/src/main/java/org/apache/comet/NativeBase.java:
##########
@@ -53,6 +53,28 @@ public abstract class NativeBase {
private static final AtomicBoolean released = new AtomicBoolean(false);
static {
+ // Arrow's BoundsChecking / NullCheckingForGet latch these in their static
initializers, so
+ // later writes are silently ignored. Set them here (not in load()) so
ordering does not
+ // depend on which Comet path runs first. These are pure JVM properties,
no native lib needed.
+ if (!(boolean) CometConf.COMET_DEBUG_ENABLED().get()) {
Review Comment:
The value of `COMET_DEBUG_ENABLED` can change over the lifetime of the
driver - not sure of the impact here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
