phillipleblanc commented on PR #2216: URL: https://github.com/apache/datafusion-ballista/pull/2216#issuecomment-5198784710
> > Give both algorithms equally sorted input. > > Sorry, I didn't realize TDigest also benefited from sorted input. It was not my intent to make inaccurate claims or skew benchmarks. I'll address that before I undraft this PR. > > Of course I'll address the rest of the feedback, but I just wanted to apologize first. No need to apologize! Nuance is hard to convey over text, its more about minimizing variables when doing comparison benchmarks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
