zhuqi-lucas opened a new issue, #24128: URL: https://github.com/apache/datafusion/issues/24128
Follow-up to #24074, per @alamb's [suggestion](https://github.com/apache/datafusion/pull/24074#discussion_r3723650241). #24074 introduced `PruningPredicateBuilder` (`.with_file_schema(...)`, `.with_error_counter(...)`, `.with_max_in_list_size(...)`, `.build(...)`/`.try_build(...)`) as the extensible entry point for constructing a `PruningPredicate`. As a follow-up we should: - Point people at `PruningPredicateBuilder` from the `PruningPredicate::try_new` doc comment. - Deprecate `PruningPredicate::try_new` (`#[deprecated]`) and migrate its call sites to the builder. - Move the construction logic into the builder so there is a single place to add future parameters. Non-blocking cleanup — no behavior change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
