alamb commented on code in PR #24030:
URL: https://github.com/apache/datafusion/pull/24030#discussion_r3693191873
##########
benchmarks/src/cancellation.rs:
##########
@@ -300,7 +300,7 @@ async fn generate_data(
});
let to_write = RecordBatch::try_from_iter(data).unwrap();
let path =
object_store::path::Path::from(format!("{file_num}.parquet").as_str());
- let object_store_writer = ParquetObjectWriter::new(Arc::clone(&store)
as _, path);
+ let object_store_writer = BufWriter::new(Arc::clone(&store) as _,
path);
Review Comment:
ParquetObjectWriter was deprecated:
https://github.com/apache/arrow-rs/issues/10308
ParquetObjectWriter is a thin wrapper around BufWriter:
https://docs.rs/parquet/latest/src/parquet/arrow/async_writer/store.rs.html#72-74
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
