alamb commented on code in PR #24030:
URL: https://github.com/apache/datafusion/pull/24030#discussion_r3729674792
##########
datafusion-examples/examples/data_io/parquet_advanced_index.rs:
##########
@@ -601,7 +605,15 @@ impl AsyncFileReader for ParquetReaderWithCache {
range: Range<u64>,
) -> BoxFuture<'_, datafusion::parquet::errors::Result<Bytes>> {
println!("get_bytes: {} Reading range {:?}", self.filename, range);
- self.inner.get_bytes(range)
+ let object_store = Arc::clone(&self.object_store);
+ let location = self.location.clone();
+ async move {
Review Comment:
this is basically the only code that the ParquetObjectReader was performing
that we didn't already have
##########
Cargo.lock:
##########
@@ -4535,12 +4544,6 @@ dependencies = [
"syn 2.0.119",
]
-[[package]]
-name = "paste"
Review Comment:
we did remove an old paste dependency 🎉
##########
datafusion/datasource-parquet/src/reader.rs:
##########
@@ -99,21 +101,10 @@ impl ParquetFileReaderFactory for
DefaultParquetFileReaderFactory {
partitioned_file.object_meta.location.as_ref(),
metrics,
);
- let store = Arc::clone(&self.store);
Review Comment:
rather than wrapping an inner ParquetObjectReader the reader now implements
the AsyncRead trait directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
