alamb commented on code in PR #24068:
URL: https://github.com/apache/datafusion/pull/24068#discussion_r3729744418
##########
datafusion/ffi/src/execution_plan.rs:
##########
@@ -474,15 +498,18 @@ impl ExecutionPlan for ForeignExecutionPlan {
#[cfg(any(test, feature = "integration-tests"))]
pub mod tests {
- use datafusion_physical_plan::Partitioning;
+ #[cfg(test)]
Review Comment:
why does this need another cfg test (isn't it already in a cfg test?)
##########
datafusion/physical-plan/src/joins/hash_join/exec.rs:
##########
@@ -1330,6 +1330,16 @@ impl ExecutionPlan for HashJoinExec {
vec![&self.left, &self.right]
}
+ fn dynamic_expressions(&self) -> Vec<Arc<dyn PhysicalExpr>> {
Review Comment:
yes please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
