jayshrivastava commented on code in PR #24068:
URL: https://github.com/apache/datafusion/pull/24068#discussion_r3732056068
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -1945,6 +1964,16 @@ impl ExecutionPlan for AggregateExec {
vec![&self.input]
}
+ fn dynamic_expressions_produced(&self) -> Vec<Arc<dyn PhysicalExpr>> {
Review Comment:
I kept it as `Arc<dyn PhysicalExpr>` and named it
`dynamic_expressions_produced` instead of `dynamic_filters_produced` to avoid
leaking the abstraction. `DynamicFilterPhysicalExpr` is just a `PhysicalExpr`.
One way this facade helps is that we can return `FFI_PhysicalExpr` in the FFI
layer (there's no `FFI_DynamicFilterPhysicalExpr`). It also helps avoid a
breaking API change if someone were to add new types of dynamic expressions
which need to be returned here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
