adriangb commented on code in PR #23683:
URL: https://github.com/apache/datafusion/pull/23683#discussion_r3735574887
##########
datafusion/proto/src/physical_plan/mod.rs:
##########
@@ -119,6 +119,388 @@ fn encode_human_display_alias(human_display: &str, alias:
&str) -> String {
)
}
+#[cfg(test)]
+mod file_scan_config_serde {
+ use super::*;
+ use arrow::datatypes::{DataType, Field};
+ use datafusion_common::{Constraint, Constraints, ScalarValue, Statistics};
+ use datafusion_datasource::file::FileSource;
+ use datafusion_datasource::file_groups::FileGroup;
+ use datafusion_datasource::file_stream::FileOpener;
+ use datafusion_datasource::{PartitionedFile, TableSchema};
+ use datafusion_execution::object_store::ObjectStoreUrl;
+ use datafusion_physical_expr::expressions::Column;
+ use datafusion_physical_expr::projection::{
+ ProjectionExpr as FileProjectionExpr, ProjectionExprs as
FileProjectionExprs,
+ };
+ use datafusion_physical_expr::{
+ LexOrdering, Partitioning, RangePartitioning, SplitPoint,
Review Comment:
`linux build test` is red on this: `PhysicalSortExpr` is used at lines 247
and 273 but never imported, so `datafusion-proto` (lib test) fails with two
`E0433: cannot find type PhysicalSortExpr in this scope`. The top-level `use
datafusion_physical_expr::LexOrdering` doesn't bring it in, and
`PhysicalSortExpr` is re-exported from the same crate this list already pulls
from.
```suggestion
LexOrdering, Partitioning, PhysicalSortExpr, RangePartitioning,
SplitPoint,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
