adriangb commented on code in PR #23683:
URL: https://github.com/apache/datafusion/pull/23683#discussion_r3735950357
##########
datafusion/proto/src/physical_plan/from_proto.rs:
##########
@@ -37,7 +37,6 @@ use datafusion_execution::object_store::ObjectStoreUrl;
use datafusion_execution::{FunctionRegistry, TaskContext};
use datafusion_expr::WindowFunctionDefinition;
use datafusion_physical_expr::expressions::{LambdaExpr, LambdaVariable};
-use datafusion_physical_expr::projection::{ProjectionExpr, ProjectionExprs};
use datafusion_physical_expr::scalar_subquery::ScalarSubqueryExpr;
use datafusion_physical_expr::{
HigherOrderFunctionExpr, LexOrdering, PhysicalSortExpr, ScalarFunctionExpr,
Review Comment:
`clippy` is red on two now-dead imports left behind by moving
`parse_protobuf_file_scan_config` / `parse_table_schema_from_proto` out of this
file (`-D unused-imports`). Neither name has any remaining occurrence in the
file, cfg-gated or otherwise.
```suggestion
HigherOrderFunctionExpr, PhysicalSortExpr, ScalarFunctionExpr,
```
The second one is line 36, which sits between diff hunks so I can't attach a
suggestion to it — it needs deleting too:
```rust
use datafusion_execution::object_store::ObjectStoreUrl;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
