ariel-miculas commented on code in PR #23619:
URL: https://github.com/apache/datafusion/pull/23619#discussion_r3735757845
##########
datafusion/physical-plan/src/sorts/merge.rs:
##########
@@ -435,7 +436,7 @@ impl<C: CursorValues> SortPreservingMergeStream<C> {
// Take the current cursor, leaving `None` in its place
let taken = self.cursors[stream_idx].take();
if let Some(prev_cursors) = &mut self.prev_cursors {
- prev_cursors[stream_idx] = taken;
+ prev_cursors[stream_idx] = taken.map(|c| c.last_value());
Review Comment:
I don't think this fits in the current datafusion memory management design:
https://github.com/apache/datafusion/blob/0646a310cdeb25ba6a091e643dddd06da7ea181e/datafusion/execution/src/memory_pool/mod.rs#L62-L71
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
