jayshrivastava commented on code in PR #24018:
URL: https://github.com/apache/datafusion/pull/24018#discussion_r3736189205
##########
datafusion/physical-expr/src/expressions/dynamic_filters/mod.rs:
##########
@@ -423,22 +423,6 @@ impl DynamicFilterPhysicalExpr {
}
}
- /// Check if this dynamic filter is being actively used by any consumers.
- ///
- /// Returns `true` if there are references beyond the producer (e.g., the
HashJoinExec
- /// that created the filter). This is useful to avoid computing expensive
filter
- /// expressions when no consumer will actually use them.
- ///
- /// # Implementation Details
- ///
- /// We check both Arc counts to handle two cases:
- /// - Transformed filters (via `with_new_children`) share the inner Arc
(inner count > 1)
- /// - Direct clones (via `Arc::clone`) increment the outer count (outer
count > 1)
- pub fn is_used(self: &Arc<Self>) -> bool {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
