peterxcli commented on code in PR #5046: URL: https://github.com/apache/datafusion-comet/pull/5046#discussion_r3737468786
########## spark/src/main/scala/org/apache/spark/sql/comet/execution/arrow/ArrowWriters.scala: ########## Review Comment: 1. added `writeUnsafe` for `writer.write(row)` calls. (this shows a little improvement, about 0.1 ns/row) 2. added spark row to arrow benchmark. also updated the benchmark result in pr description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
