peterxcli commented on PR #5046: URL: https://github.com/apache/datafusion-comet/pull/5046#issuecomment-5219965085
@mbutrovich Thanks for the review, filed a followup for exploring "no-null bulk case using arrow-java's existing buffer-level copy APIs", added unsafe write function for `writer.write(row)` to bypass the capacity check in the original safe write api and benchmark that clone the behaviour from `SparkColumnarArrowReader`, shows about `1.37×` faster improvement(updated in PR description). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
