nuno-faria commented on code in PR #24134:
URL: https://github.com/apache/datafusion/pull/24134#discussion_r3738248088
##########
datafusion/functions-nested/src/sort.rs:
##########
Review Comment:
I'm not sure about the name of the arguments, since the argument `desc` can
be `'asc'` and `nulls_first` can be `'nulls last'`. What about `order` and
`nulls` or something like that?
Also, should we also add an example using the additional arguments?
##########
datafusion/functions-nested/src/array_has.rs:
##########
@@ -994,22 +994,22 @@ fn array_has_any_with_scalar_general(
#[user_doc(
doc_section(label = "Array Functions"),
- description = "Returns true if all elements of sub-array exist in array.",
- syntax_example = "array_has_all(array, sub-array)",
+ description = "Returns true if all elements of sub_array exist in array.",
+ syntax_example = "array_has_all(array, sub_array)",
sql_example = r#"```sql
> select array_has_all([1, 2, 3, 4], [2, 3]);
-+--------------------------------------------+
++---------------------------------------------+
| array_has_all(List([1,2,3,4]), List([2,3])) |
-+--------------------------------------------+
-| true |
-+--------------------------------------------+
++---------------------------------------------+
+| true |
Review Comment:
Maybe in a followup we can use a simple script to check if they are valid,
similar to the markdown ones. Here are the invalid ones:
```
datafusion/functions/src/core/arrow_field.rs: line 39
datafusion/functions/src/core/nvl.rs: line 34
datafusion/functions/src/core/with_metadata.rs: line 33
datafusion/functions/src/core/with_metadata.rs: line 39
datafusion/functions/src/datetime/date_trunc.rs: line 191
datafusion/functions/src/datetime/date_trunc.rs: line 197
datafusion/functions/src/datetime/to_date.rs: line 45
datafusion/functions/src/datetime/to_date.rs: line 51
datafusion/functions/src/datetime/to_timestamp.rs: line 274
datafusion/functions/src/math/round.rs: line 166
datafusion/functions-aggregate/src/approx_percentile_cont_with_weight.rs:
line 94
datafusion/functions-aggregate/src/array_agg.rs: line 80
datafusion/functions-aggregate/src/average.rs: line 86
datafusion/functions-aggregate/src/bool_and_or.rs: line 100
datafusion/functions-aggregate/src/bool_and_or.rs: line 229
datafusion/functions-aggregate/src/count.rs: line 141
datafusion/functions-aggregate/src/grouping.rs: line 48
datafusion/functions-aggregate/src/median.rs: line 75
datafusion/functions-aggregate/src/min_max.rs: line 87
datafusion/functions-aggregate/src/min_max.rs: line 459
datafusion/functions-aggregate/src/percentile_cont.rs: line 103
datafusion/functions-aggregate/src/regr.rs: line 183
datafusion/functions-aggregate/src/stddev.rs: line 56
datafusion/functions-aggregate/src/stddev.rs: line 160
datafusion/functions-aggregate/src/string_agg.rs: line 77
datafusion/functions-aggregate/src/sum.rs: line 156
datafusion/functions-nested/src/array_avg.rs: line 52
datafusion/functions-nested/src/array_filter.rs: line 58
datafusion/functions-nested/src/array_has.rs: line 1002
datafusion/functions-nested/src/array_has.rs: line 1070
datafusion/functions-nested/src/array_normalize.rs: line 55
datafusion/functions-nested/src/array_scale.rs: line 53
datafusion/functions-nested/src/array_sum.rs: line 52
datafusion/functions-nested/src/array_transform.rs: line 57
datafusion/functions-nested/src/cosine_distance.rs: line 54
datafusion/functions-nested/src/except.rs: line 55
datafusion/functions-nested/src/except.rs: line 61
datafusion/functions-nested/src/extract.rs: line 794
datafusion/functions-nested/src/extract.rs: line 978
datafusion/functions-nested/src/inner_product.rs: line 54
datafusion/functions-nested/src/position.rs: line 69
datafusion/functions-nested/src/remove.rs: line 61
datafusion/functions-nested/src/remove.rs: line 171
datafusion/functions-nested/src/remove.rs: line 300
datafusion/functions-nested/src/string.rs: line 173
datafusion/functions-nested/src/string.rs: line 179
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
