alamb commented on code in PR #11995:
URL: https://github.com/apache/datafusion/pull/11995#discussion_r1717505006
##########
datafusion/physical-expr/src/expressions/binary.rs:
##########
@@ -131,32 +132,27 @@ impl std::fmt::Display for BinaryExpr {
}
}
-/// Invoke a compute kernel on a pair of binary data arrays
Review Comment:
this macro formulation I think really obscures what is going on and actually
is more verbose than just making a function that calls concat_elements
directly, so I did
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
