alamb commented on code in PR #11995:
URL: https://github.com/apache/datafusion/pull/11995#discussion_r1717505404
##########
datafusion/physical-expr/src/expressions/binary/kernels.rs:
##########
@@ -27,8 +27,34 @@ use arrow::datatypes::DataType;
use datafusion_common::internal_err;
use datafusion_common::{Result, ScalarValue};
+use arrow_schema::ArrowError;
use std::sync::Arc;
+/// Returns the elementwise concatenation of a [`StringViewArary`].
+///
+/// An index of the resulting [`StringViewArray`] is null if any of
+/// `StringViewArary` are null at that location.
+///
+/// ```text
+/// e.g:
+///
+/// ["Hello"] + ["World"] = ["HelloWorld"]
+///
+/// ["a", "b"] + [None, "c"] = [None, "bc"]
+/// ```
+///
+/// An error will be returned if `left` and `right` have different lengths
+///
+/// TODO: port this upstream to arrow-rs (TODO FILE TICKET AND REFERENCE HERE)
Review Comment:
The idea would be to fill out this function (and eventually port it upstream
to arrow-rs)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
