avantgardnerio commented on code in PR #24035:
URL: https://github.com/apache/datafusion/pull/24035#discussion_r3741799272
##########
datafusion/physical-plan/src/windows/bounded_window_agg_exec.rs:
##########
@@ -140,9 +187,17 @@ impl BoundedWindowAggExec {
ordered_partition_by_indices,
cache: Arc::new(cache),
can_repartition,
+ state_observer: None,
})
}
+ /// Install a [`WindowStateObserver`] that receives each PARTITION BY
+ /// group's finalized window state at partition close.
+ pub fn with_state_observer(mut self, observer: Arc<dyn
WindowStateObserver>) -> Self {
Review Comment:
I updated it, and `with_state_observer` now takes `Option<Arc<dyn
WindowStateObserver>>` and `with_new_children` collapses to the single-chain
form
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
