alamb commented on code in PR #24035:
URL: https://github.com/apache/datafusion/pull/24035#discussion_r3723559606
##########
datafusion/physical-expr/src/window/window_expr.rs:
##########
@@ -647,6 +647,19 @@ pub struct WindowState {
pub state: WindowAggState,
pub window_fn: WindowFn,
}
+
+impl WindowState {
+ /// `Accumulator::state()` if this window function is an aggregate, `None`
+ /// otherwise (built-in functions like `row_number`, `rank`, `lead`/`lag`
+ /// have no serializable accumulator state).
+ pub fn aggregate_state(&mut self) -> Result<Option<Vec<ScalarValue>>> {
+ match &mut self.window_fn {
+ WindowFn::Aggregate(accumulator) => accumulator.state().map(Some),
+ WindowFn::Builtin(_) => Ok(None),
Review Comment:
Filed a PR to improve the docs
- https://github.com/apache/datafusion/pull/24118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
