alamb commented on code in PR #23854:
URL: https://github.com/apache/datafusion/pull/23854#discussion_r3758046872
##########
datafusion/physical-plan/src/joins/hash_join/shared_bounds.rs:
##########
@@ -688,38 +693,97 @@ impl SharedBuildAccumulator {
}
}
- let filter_expr = if has_canceled_unknown {
- let mut when_then_branches = empty_partition_ids
+ let filter_expr = if has_canceled_unknown
Review Comment:
as a follow on it might be nice to break this function into smaller
functions (mostly so they can be documented more clearly) -- the techniques
here are quite clever
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
