peterxcli commented on code in PR #23854:
URL: https://github.com/apache/datafusion/pull/23854#discussion_r3758479925
##########
datafusion/physical-plan/src/joins/hash_join/shared_bounds.rs:
##########
@@ -688,38 +693,97 @@ impl SharedBuildAccumulator {
}
}
- let filter_expr = if has_canceled_unknown {
- let mut when_then_branches = empty_partition_ids
+ let filter_expr = if has_canceled_unknown
Review Comment:
let me handle this, I also spent quite some time understanding this part 😆
btw, not sure whether it's better to open a follow-up PR directly or file an
issue to document/track this. wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
