akshaychitneni commented on code in PR #2244: URL: https://github.com/apache/datafusion-ballista/pull/2244#discussion_r3759984617
########## chaos-testing/tests/k8s.rs: ########## @@ -0,0 +1,113 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! Kubernetes (kind) backend scenarios. +//! +//! Gated behind the `k8s` feature and `CHAOS_BACKEND=kind`, so the default +//! `cargo test` never touches a cluster. Run with the kind runbook in the crate +//! README: +//! +//! ```sh +//! dev/build-chaos-docker.sh +//! kind create cluster --config chaos-testing/k8s/kind-config.yaml +//! kind load docker-image ballista-chaos-scheduler:test ballista-chaos-executor:test +//! CHAOS_BACKEND=kind cargo test -p ballista-chaos --features k8s --test k8s -- --test-threads=1 +//! ``` +#![cfg(feature = "k8s")] + +use ballista::prelude::{SessionConfigExt, SessionContextExt}; +use chaos_testing::fixture::Fixture; +use chaos_testing::k8s::K8sCluster; +use datafusion::arrow::util::pretty::pretty_format_batches; +use datafusion::execution::session_state::SessionStateBuilder; +use datafusion::prelude::{SessionConfig, SessionContext}; + +/// The k8s scenarios need a running kind cluster with the chaos images loaded; +/// they are opt-in via `CHAOS_BACKEND=kind` so a plain `cargo test` skips them. +fn kind_backend_selected() -> bool { Review Comment: This might be needed - the CHAOS_BACKEND=kind gate controls whether we actually reach a cluster ########## chaos-testing/tests/k8s.rs: ########## @@ -0,0 +1,113 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! Kubernetes (kind) backend scenarios. +//! +//! Gated behind the `k8s` feature and `CHAOS_BACKEND=kind`, so the default +//! `cargo test` never touches a cluster. Run with the kind runbook in the crate +//! README: +//! +//! ```sh +//! dev/build-chaos-docker.sh +//! kind create cluster --config chaos-testing/k8s/kind-config.yaml +//! kind load docker-image ballista-chaos-scheduler:test ballista-chaos-executor:test +//! CHAOS_BACKEND=kind cargo test -p ballista-chaos --features k8s --test k8s -- --test-threads=1 +//! ``` +#![cfg(feature = "k8s")] + +use ballista::prelude::{SessionConfigExt, SessionContextExt}; +use chaos_testing::fixture::Fixture; +use chaos_testing::k8s::K8sCluster; +use datafusion::arrow::util::pretty::pretty_format_batches; +use datafusion::execution::session_state::SessionStateBuilder; +use datafusion::prelude::{SessionConfig, SessionContext}; + +/// The k8s scenarios need a running kind cluster with the chaos images loaded; +/// they are opt-in via `CHAOS_BACKEND=kind` so a plain `cargo test` skips them. +fn kind_backend_selected() -> bool { Review Comment: This is needed as the CHAOS_BACKEND=kind gate controls whether we actually reach a cluster -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
