JSOD11 commented on code in PR #23903:
URL: https://github.com/apache/datafusion/pull/23903#discussion_r3765990168
##########
datafusion/physical-plan/src/execution_plan.rs:
##########
@@ -936,6 +1034,27 @@ pub trait ExecutionPlan: Any + Debug + DisplayAs + Send +
Sync {
}
}
+/// Options for [`ExecutionPlan::replace_children`]
+#[derive(Debug, Clone, Copy, PartialEq, Eq)]
+pub struct ReplaceChildrenOptions {
+ /// Describes how plan properties should be handled for the replacement
+ /// children.
+ pub children_properties: ChildrenPropertiesMode,
+}
+
+/// Indicates whether the plan properties of the new children must be
recomputed.
+///
+/// Part of [`ReplaceChildrenOptions`].
+#[derive(Debug, Clone, Copy, PartialEq, Eq)]
+pub enum ChildrenPropertiesMode {
+ /// The plan properties of the new children are identical to the properties
+ /// of the existing children, so we can skip recomputation.
+ SameProperties,
Review Comment:
I like this name, matches the other variant better. Just changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
