JSOD11 commented on code in PR #23903:
URL: https://github.com/apache/datafusion/pull/23903#discussion_r3744814174
##########
datafusion/physical-plan/src/execution_plan.rs:
##########
@@ -264,14 +264,34 @@ pub trait ExecutionPlan: Any + Debug + DisplayAs + Send +
Sync {
/// joins).
fn children(&self) -> Vec<&Arc<dyn ExecutionPlan>>;
+ /// Returns a clone of the existing plan with the children replaced,
skipping
+ /// recomputation of plan properties if possible as indicated by the hint.
+ #[expect(deprecated)]
+ fn replace_children(
+ self: Arc<Self>,
+ children: Vec<Arc<dyn ExecutionPlan>>,
+ hint: ChildrenPropertiesHint,
Review Comment:
Yeah this is a good point, see comment below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
