Rachelint commented on code in PR #11894:
URL: https://github.com/apache/datafusion/pull/11894#discussion_r1718185142


##########
datafusion/core/src/datasource/physical_plan/parquet/mod.rs:
##########
@@ -391,6 +391,12 @@ impl ParquetExecBuilder {
             &projected_output_ordering,
             &base_config,
         );
+
+        base_config

Review Comment:
   > that is an interesting idea
   
   But it still seem to make some long queries slower...
   
   After finish the refactor work about blocked accumulators sketch. I plan to 
try to reduce the cost of the expansive clone scalar values like 
`ScalarValue::String`(`String` -> `Arc<str>`), and see if it can faster the 
shorts and don't slower the longs...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to