nuno-faria commented on code in PR #24118:
URL: https://github.com/apache/datafusion/pull/24118#discussion_r3769753991
##########
datafusion/physical-expr/src/window/window_expr.rs:
##########
@@ -610,9 +610,16 @@ pub(crate) fn get_orderby_values(order_by_columns:
Vec<SortColumn>) -> Vec<Array
order_by_columns.into_iter().map(|s| s.values).collect()
}
+/// State for incrementally evaluating a window function
+/// within a partition, created by [`WindowExpr::create_window_fn`].
#[derive(Debug)]
pub enum WindowFn {
+ /// A "normal" window function, such as `lead` or `lag`, evaluated via a
+ /// [`PartitionEvaluator`]. Despite the name, it is used for all window
+ /// function that is not an aggregate function.
Review Comment:
nit: "... for all window function that is not aggregate function" -> "for
all window functions that are not aggregate functions"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
