2010YOUY01 commented on PR #23777: URL: https://github.com/apache/datafusion/pull/23777#issuecomment-5275461170
Thank you, the implementation looks good to me. There is a related inefficiency that was reported recently. I'll try to look into it soon and then figure out how we should proceed with this PR. Even if we can't eliminate the extra overhead, we can still add a config option to enable or disable this hash-set-based deduplication, this shouldn't be a hard blocker. https://github.com/apache/datafusion/issues/24310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
