emilk opened a new pull request, #24322:
URL: https://github.com/apache/datafusion/pull/24322
## Which issue does this PR close?
- Part of #18467
- Follow-up to #24066
## Rationale for this change
More `allow`-by-default clippy lints that simplify code, catch bugs, or
improve performance.
Every lint here was verified to be outside the default-warn groups, so none
is a no-op.
## What changes are included in this PR?
**One commit per lint, including its fixes**, so any single lint can be
reverted on its own.
The first commit is the exception: 19 lints that had zero hits and need no
code changes.
Two real bugs fell out of `literal_string_with_formatting_args`, where a
`{placeholder}` was
printed verbatim instead of interpolated:
* `benchmarks/src/nlj.rs`: `"NLJ benchmark Q{query_id} failed…".to_string()`
* `parquet_advanced_index.rs`: `.expect("metadata for file not found:
{filename}")`
`fallible_impl_from` also flagged that `From<protobuf::Constraint> for
Constraint` panics on a
message with an unset `constraint_mode`. Fixing that needs a breaking change
to `TryFrom`, so it
is only marked with `#[expect]` here.
## Are these changes tested?
Covered by existing tests plus the clippy CI job. I also ran the extended
test suite locally.
## Are there any user-facing changes?
One non-breaking signature change: `format_human_display` and a few private
helpers now take `T`
instead of `Option<T>` (`clippy::single_option_map`). No public API changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
