emilk commented on code in PR #24322:
URL: https://github.com/apache/datafusion/pull/24322#discussion_r3775227257
##########
benchmarks/src/nlj.rs:
##########
@@ -226,7 +226,7 @@ impl RunOpt {
}
Err(e) => {
return Err(DataFusionError::Context(
- "NLJ benchmark Q{query_id} failed with
error:".to_string(),
+ format!("NLJ benchmark Q{query_id} failed with
error:"),
Review Comment:
It was silently printing the literal text `Q{query_id}`. The lint found a
second one too, in `parquet_advanced_index.rs`.
-- Claude
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
