alamb commented on code in PR #24376:
URL: https://github.com/apache/datafusion/pull/24376#discussion_r3786374650
##########
datafusion-cli/src/functions.rs:
##########
@@ -241,14 +241,14 @@ impl TableProvider for ParquetMetadataTable {
async fn scan(
&self,
_state: &dyn Session,
- projection: Option<&Vec<usize>>,
+ projection: Option<&[usize]>,
Review Comment:
I think this makes sense and is better rust best practice anyways
##########
datafusion/session/src/table.rs:
##########
@@ -209,18 +209,33 @@ pub trait TableProvider: Any + Debug + Sync + Send {
/// A [`ScanResult`] containing the [`ExecutionPlan`] for scanning the
table
///
/// See [`Self::scan`] for detailed documentation about projection,
filters, and limits.
- async fn scan_with_args<'a>(
- &self,
- state: &dyn Session,
+ // Hand-written `#[async_trait]` expansion to reduce compile time. See
+ // <https://github.com/apache/datafusion/issues/13814>.
+ //
+ // `scan` is called eagerly here so the returned future captures only the
Review Comment:
I think it would be ok here to simply leave a pointer to the issue rather
than repeat the whole explanation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
