Dandandan commented on PR #24376: URL: https://github.com/apache/datafusion/pull/24376#issuecomment-5298046421
> FWIW I could not reproduce the reported compilation speedup > > I had code run the PR's reported command, `cargo rustc -p datafusion-session --lib`, five times per revision. Dependencies were warmed beforehand, and `datafusion/session/src/lib.rs` was touched before each measured run to force only `datafusion-session` to recompile. Runs were interleaved baseline/PR. > > run merge-base (`ec110cea18`) PR (`2c7a7ba49a`) > 1 0.38s 0.39s > 2 0.38s 0.38s > 3 0.38s 0.38s > 4 0.38s 0.39s > 5 0.39s 0.38s > **mean** **0.382s** **0.384s** > **median** **0.380s** **0.380s** > Is there some other way you were testing? Yes, I tested it building the whole workspace and then looking at the contribution of datafusion-session. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
