alamb commented on code in PR #24389:
URL: https://github.com/apache/datafusion/pull/24389#discussion_r3789203472
##########
datafusion/physical-plan/src/union.rs:
##########
@@ -916,6 +916,22 @@ fn union_schema(inputs: &[Arc<dyn ExecutionPlan>]) ->
Result<SchemaRef> {
}
let first_schema = inputs[0].schema();
+
+ // Fast path: when every input already shares the first input's schema, the
+ // field-by-field metadata/nullability merge below is redundant work that
Review Comment:
I think we should slim this comment down - the first sentence is probably
enough. The last sentence is unecessary as it is restating in english what the
code right below it clearly does so it is redundant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
