haohuaijin opened a new pull request, #24411: URL: https://github.com/apache/datafusion/pull/24411
## Which issue does this PR close? - Closes #24410. ## Rationale for this change Inline ORDER BY handling incorrectly removes percentile or weight arguments from approximate percentile aggregates. ## What changes are included in this PR? Only remove the first aggregate argument when it matches the inline ordering expression. Add regression coverage for approx_percentile_cont and approx_percentile_cont_with_weight. ## Are these changes tested? Yes. The aggregate.slt regression tests, ./dev/rust_lint.sh, and cargo clippy --all-targets --all-features -- -D warnings all pass. ## Are there any user-facing changes? Valid approximate percentile queries using inline ORDER BY now plan and execute successfully. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
