Jefffrey commented on code in PR #24411:
URL: https://github.com/apache/datafusion/pull/24411#discussion_r3791900371
##########
datafusion/sql/src/expr/function.rs:
##########
Review Comment:
could we driveby to remove this `is_builtin_ordered_set` logic; these UDFs
already implement `supports_within_group_clause()` above so i think its
redundant
##########
datafusion/sql/src/expr/function.rs:
##########
@@ -788,6 +784,12 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
);
}
+ // Remove the ordered value only when it is explicitly
repeated.
Review Comment:
```suggestion
// Remove the ordered value only when it is
explicitly repeated.
// This ensures these are equivalent:
// approx_percentile_cont(c3, 0.95, 200 ORDER BY
c3)
// approx_percentile_cont(0.95, 200 ORDER BY c3)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
