github-actions[bot] commented on PR #24227: URL: https://github.com/apache/datafusion/pull/24227#issuecomment-5309972905
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v54.1.0 (current) Built [ 60.821s] (current) Parsing datafusion v54.1.0 (current) Parsed [ 0.035s] (current) Building datafusion v54.1.0 (baseline) Built [ 58.577s] (baseline) Parsing datafusion v54.1.0 (baseline) Parsed [ 0.034s] (baseline) Checking datafusion v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.601s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 121.795s] datafusion Building datafusion-common v54.1.0 (current) Built [ 34.685s] (current) Parsing datafusion-common v54.1.0 (current) Parsed [ 0.060s] (current) Building datafusion-common v54.1.0 (baseline) Built [ 34.284s] (baseline) Parsing datafusion-common v54.1.0 (baseline) Parsed [ 0.063s] (baseline) Checking datafusion-common v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.645s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip --- failure constructible_struct_adds_field: struct exhaustively constructible through public API adds field --- Description: A pub struct that could be exhaustively constructed with a literal using only public API has a new pub field, breaking existing exhaustive literals. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/constructible_struct_adds_field.ron Failed in: field ParquetOptions.enable_rle_to_dictionary in /home/runner/work/datafusion/datafusion/datafusion/common/src/config.rs:1196 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 70.837s] datafusion-common Building datafusion-datasource-parquet v54.1.0 (current) Built [ 48.961s] (current) Parsing datafusion-datasource-parquet v54.1.0 (current) Parsed [ 0.032s] (current) Building datafusion-datasource-parquet v54.1.0 (baseline) Built [ 48.795s] (baseline) Parsing datafusion-datasource-parquet v54.1.0 (baseline) Parsed [ 0.033s] (baseline) Checking datafusion-datasource-parquet v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.150s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 99.352s] datafusion-datasource-parquet Building datafusion-proto v54.1.0 (current) Built [ 54.025s] (current) Parsing datafusion-proto v54.1.0 (current) Parsed [ 0.017s] (current) Building datafusion-proto v54.1.0 (baseline) Built [ 54.414s] (baseline) Parsing datafusion-proto v54.1.0 (baseline) Parsed [ 0.019s] (baseline) Checking datafusion-proto v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.125s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 109.886s] datafusion-proto Building datafusion-proto-common v54.1.0 (current) Built [ 22.424s] (current) Parsing datafusion-proto-common v54.1.0 (current) Parsed [ 0.046s] (current) Building datafusion-proto-common v54.1.0 (baseline) Built [ 22.563s] (baseline) Parsing datafusion-proto-common v54.1.0 (baseline) Parsed [ 0.048s] (baseline) Checking datafusion-proto-common v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 1.058s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip --- failure constructible_struct_adds_field: struct exhaustively constructible through public API adds field --- Description: A pub struct that could be exhaustively constructed with a literal using only public API has a new pub field, breaking existing exhaustive literals. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/constructible_struct_adds_field.ron Failed in: field ParquetOptions.enable_rle_to_dictionary in /home/runner/work/datafusion/datafusion/datafusion/proto-common/src/generated/prost.rs:868 field ParquetOptions.enable_rle_to_dictionary in /home/runner/work/datafusion/datafusion/datafusion/proto-common/src/generated/prost.rs:868 field ParquetOptions.enable_rle_to_dictionary in /home/runner/work/datafusion/datafusion/datafusion/proto-common/src/generated/prost.rs:868 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 47.265s] datafusion-proto-common Building datafusion-proto-models v54.1.0 (current) Built [ 25.553s] (current) Parsing datafusion-proto-models v54.1.0 (current) Parsed [ 0.129s] (current) Building datafusion-proto-models v54.1.0 (baseline) Built [ 25.327s] (baseline) Parsing datafusion-proto-models v54.1.0 (baseline) Parsed [ 0.128s] (baseline) Checking datafusion-proto-models v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 1.765s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip --- failure constructible_struct_adds_field: struct exhaustively constructible through public API adds field --- Description: A pub struct that could be exhaustively constructed with a literal using only public API has a new pub field, breaking existing exhaustive literals. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/constructible_struct_adds_field.ron Failed in: field ParquetOptions.enable_rle_to_dictionary in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/datafusion_proto_common.rs:868 field ParquetOptions.enable_rle_to_dictionary in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/datafusion_proto_common.rs:868 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 54.495s] datafusion-proto-models Building datafusion-sqllogictest v54.1.0 (current) Built [ 101.048s] (current) Parsing datafusion-sqllogictest v54.1.0 (current) Parsed [ 0.021s] (current) Building datafusion-sqllogictest v54.1.0 (baseline) Built [ 101.122s] (baseline) Parsing datafusion-sqllogictest v54.1.0 (baseline) Parsed [ 0.022s] (baseline) Checking datafusion-sqllogictest v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.103s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 205.091s] datafusion-sqllogictest ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
