0lai0 commented on issue #5091:
URL:
https://github.com/apache/datafusion-comet/issues/5091#issuecomment-5325720667
Follow-up on the covariance item: the filter regression is real, but the
readability problem this issue originally flagged is independent of which
kernel you reach for. The dual flatten() iterators advanced conditionally on
is_valid(i) can be replaced with
```
values1.iter().zip(values2.iter()).for_each(|pair| {
if let (Some(a), Some(b)) = pair {
// existing update logic
}
});
```
No extra allocation, same traversal count as today, and the null-sync
becomes a single pattern match instead of two independent iterators. Worth
trying before this item gets written off.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
