patrickswedish commented on PR #24394: URL: https://github.com/apache/datafusion/pull/24394#issuecomment-5333644160
Hi @kosiew, thank you very much for reviewing and pointing that out! I have resolved the missing \RecordBatchStream\ import, addressed the qualification and integration test requirements, and fixed \AggregateExec::execute_input\ to adapt batches directly to \self.input.schema()\. The entire local validation battery (\cargo fmt --all --check\, \cargo test -p datafusion-common --lib nested_struct::adapt_schema_tests\, \cargo test -p datafusion-physical-plan --lib aggregates\, and \cargo test -p datafusion --test core_integration nested_nullability\, plus \cargo clippy --all-targets -- -D warnings\) is now completely green with zero errors. The branch has been squashed into 1 clean atomic commit (\47de466\) and pushed. Whenever you have a chance, please approve the workflow runs on GitHub Actions. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
