jcsherin commented on code in PR #12030: URL: https://github.com/apache/datafusion/pull/12030#discussion_r1719704089
########## datafusion/physical-plan/src/windows/mod.rs: ########## @@ -375,6 +378,16 @@ impl BuiltInWindowFunctionExpr for WindowUDFExpr { fn reverse_expr(&self) -> Option<Arc<dyn BuiltInWindowFunctionExpr>> { None } + + fn get_result_ordering(&self, schema: &SchemaRef) -> Option<PhysicalSortExpr> { + self.fun + .sort_options() Review Comment: The user-defined window function can specify its result ordering which will be used for updating ordering equivalences. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org