jcsherin commented on code in PR #12030:
URL: https://github.com/apache/datafusion/pull/12030#discussion_r1719708163
##########
datafusion/proto/proto/datafusion.proto:
##########
@@ -481,7 +481,8 @@ message ScalarUDFExprNode {
}
enum BuiltInWindowFunction {
- ROW_NUMBER = 0;
+ UNSPECIFIED = 0; //
https://protobuf.dev/programming-guides/dos-donts/#unspecified-enum
+ // ROW_NUMBER = 0;
Review Comment:
The proto enum requires the first value to be zero. See:
https://protobuf.dev/programming-guides/dos-donts/#unspecified-enum
Leaving the older value commented out instead of removing it so we know that
it was `ROW_NUMBER`. This will anyways be removed once all the other built-ins
are moved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
