shinzoxD commented on code in PR #24399: URL: https://github.com/apache/datafusion/pull/24399#discussion_r3815257619
########## datafusion/functions/src/math/log.rs: ########## Review Comment: Addressed in c383b0714d7f112b61779c2c2e6bb4d00118d071: `log(a, a) => 1` now applies only when `a` is a known strictly positive finite literal, so `SELECT log(0.0::float8, 0.0::float8)` is a domain error instead of `1.0`. `log(a, power(a, b)) => b` is similarly guarded and only rewrites when the power result is known strictly positive (covers a zero base and underflow-to-zero). Added planner-level SLT regressions for those forms; `log(2, 2)` and `log(2, power(2, 3))` still simplify. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
