shinzoxD commented on PR #24399: URL: https://github.com/apache/datafusion/pull/24399#issuecomment-5345694859
@kosiew Addressed in c383b0714d7f112b61779c2c2e6bb4d00118d071: - Guarded the `log(a, a)` and `log(a, power(a, b))` simplifications so they cannot bypass the log-of-zero domain error. - Added planner-level SLT cases for `log(0, 0)` and `log(a, power(a, b))` when the power result is zero, while keeping the valid `log(2, 2)` rewrite. - Added a table-driven unit test for every changed physical type (Float16/32/64, Decimal32/64/128/256). - Formatted `docs/source/user-guide/expressions.md` with prettier 2.7.1 to fix the CI docs check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
