kosiew commented on PR #24364: URL: https://github.com/apache/datafusion/pull/24364#issuecomment-5351799738
@comphead fix(runend,union): remove object‑identity branches/tests, add size_without_input_buffer, update metrics after successful resize, add failed‑resize regression assertion > Array-object dedup silently fails for Union / RunEndEncoded - Removed Union/RunEnd object‑identity branches/tests. > Fragile subtract-input_buffer in size() - Adds size_without_input_buffer(). > Metric set before try_resize succeeds - Updates metrics only after successful resize. - Adds failed‑resize metric regression assertion. > Test suite has ~200 LoC of removable redundancy The direct stream test covers reservation growth, release, and a direct input-buffer alias; the nested test covers recursive child accounting. Likewise, the recording-pool test verifies retain/release transitions, while the bounded-pool test verifies the externally observable failure. `TrackConsumersPool` exposes current/peak snapshots, not the ordered deltas needed for the transition assertion. I think it's a good idea keep the remaining focused tests separate because they assert distinct contracts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
