theirix commented on code in PR #24419:
URL: https://github.com/apache/datafusion/pull/24419#discussion_r3819131175
##########
datafusion/functions-aggregate/src/median.rs:
##########
@@ -91,6 +68,7 @@ make_udaf_expr_and_func!(
#[derive(PartialEq, Eq, Hash, Debug)]
pub struct Median {
signature: Signature,
+ percentile_cont: PercentileCont,
Review Comment:
We've done forwarding calls to a child UDF before in other functions. I can
try a rewrite approach and tell if it is more concise - I thought it could hurt
programmatic usage in tests (like the mentioned test_oom)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
