devanbenz commented on code in PR #12000:
URL: https://github.com/apache/datafusion/pull/12000#discussion_r1719866194
##########
datafusion/core/src/dataframe/mod.rs:
##########
@@ -2869,6 +2876,39 @@ mod tests {
Ok(())
}
+ #[tokio::test]
+ async fn test_window_function_with_column() -> Result<()> {
+ let df = test_table().await?.select_columns(&["c1", "c2", "c3"])?;
+ let ctx = SessionContext::new();
+ let df_impl = DataFrame::new(ctx.state(), df.plan.clone());
+ let func = Expr::WindowFunction(WindowFunction::new(
+ WindowFunctionDefinition::BuiltInWindowFunction(
+ BuiltInWindowFunction::RowNumber,
+ ),
+ vec![],
+ ))
+ .alias("row_num");
Review Comment:
Sounds good I went ahead and used the more concise method call. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
