github-actions[bot] commented on PR #24497:
URL: https://github.com/apache/datafusion/pull/24497#issuecomment-5365493716

   <!-- semver-check-comment -->
   Thank you for opening this pull request!
   
   Reviewer note: 
[cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) 
reported the current version number is not SemVer-compatible with the changes 
in this pull request (compared against the base branch).
   
   <details>
   <summary>Details</summary>
   
   ```
        Cloning apache/main
       Building datafusion v55.0.0 (current)
          Built [  59.890s] (current)
        Parsing datafusion v55.0.0 (current)
         Parsed [   0.035s] (current)
       Building datafusion v55.0.0 (baseline)
          Built [  58.596s] (baseline)
        Parsing datafusion v55.0.0 (baseline)
         Parsed [   0.035s] (baseline)
       Checking datafusion v55.0.0 -> v55.0.0 (no change; assume patch)
        Checked [   0.606s] 223 checks: 223 pass, 31 skip
        Summary no semver update required
       Finished [ 120.828s] datafusion
       Building datafusion-datasource v55.0.0 (current)
          Built [  43.212s] (current)
        Parsing datafusion-datasource v55.0.0 (current)
         Parsed [   0.031s] (current)
       Building datafusion-datasource v55.0.0 (baseline)
          Built [  43.285s] (baseline)
        Parsing datafusion-datasource v55.0.0 (baseline)
         Parsed [   0.032s] (baseline)
       Checking datafusion-datasource v55.0.0 -> v55.0.0 (no change; assume 
patch)
        Checked [   0.246s] 223 checks: 223 pass, 31 skip
        Summary no semver update required
       Finished [  87.919s] datafusion-datasource
       Building datafusion-ffi v55.0.0 (current)
          Built [  55.029s] (current)
        Parsing datafusion-ffi v55.0.0 (current)
         Parsed [   0.063s] (current)
       Building datafusion-ffi v55.0.0 (baseline)
          Built [  55.499s] (baseline)
        Parsing datafusion-ffi v55.0.0 (baseline)
         Parsed [   0.066s] (baseline)
       Checking datafusion-ffi v55.0.0 -> v55.0.0 (no change; assume patch)
        Checked [   0.262s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip
   
   --- failure constructible_struct_adds_field: struct exhaustively 
constructible through public API adds field ---
   
   Description:
   A pub struct that could be exhaustively constructed with a literal using 
only public API has a new pub field, breaking existing exhaustive literals.
           ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html
          impl: 
https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/constructible_struct_adds_field.ron
   
   Failed in:
     field FFI_PlanProperties.group_contiguous_exprs in 
/home/runner/work/datafusion/datafusion/datafusion/ffi/src/plan_properties.rs:72
   
        Summary semver requires new major version: 1 major and 0 minor checks 
failed
       Finished [ 112.249s] datafusion-ffi
       Building datafusion-physical-optimizer v55.0.0 (current)
          Built [  41.432s] (current)
        Parsing datafusion-physical-optimizer v55.0.0 (current)
         Parsed [   0.021s] (current)
       Building datafusion-physical-optimizer v55.0.0 (baseline)
          Built [  40.683s] (baseline)
        Parsing datafusion-physical-optimizer v55.0.0 (baseline)
         Parsed [   0.023s] (baseline)
       Checking datafusion-physical-optimizer v55.0.0 -> v55.0.0 (no change; 
assume patch)
        Checked [   0.116s] 223 checks: 223 pass, 31 skip
        Summary no semver update required
       Finished [  83.301s] datafusion-physical-optimizer
       Building datafusion-physical-plan v55.0.0 (current)
          Built [  38.462s] (current)
        Parsing datafusion-physical-plan v55.0.0 (current)
         Parsed [   0.151s] (current)
       Building datafusion-physical-plan v55.0.0 (baseline)
          Built [  38.793s] (baseline)
        Parsing datafusion-physical-plan v55.0.0 (baseline)
         Parsed [   0.152s] (baseline)
       Checking datafusion-physical-plan v55.0.0 -> v55.0.0 (no change; assume 
patch)
        Checked [   0.626s] 223 checks: 223 pass, 31 skip
        Summary no semver update required
       Finished [  79.271s] datafusion-physical-plan
   ```
   
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to