buraksenn commented on code in PR #24233:
URL: https://github.com/apache/datafusion/pull/24233#discussion_r3830655978
##########
datafusion/proto-models/proto/datafusion.proto:
##########
@@ -1291,10 +1294,14 @@ message CsvScanExecNode {
}
bool newlines_in_values = 7;
bool truncate_rows = 8;
+ // Custom line terminator. Absent means the default newline terminator.
+ optional string terminator = 9;
Review Comment:
Thanks for the review and suggestion @kosiew. I've applied it with the
additional test case below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]