NoahKusaba opened a new pull request, #2354:
URL: https://github.com/apache/datafusion-ballista/pull/2354
# Which issue does this PR close?
Closes #.
# Rationale for this change
The job-completion poll loop in `SchedulerTest::run_with_subscriber` used `_
=> continue`,
which skips the `sleep(100)` below the match. Once a job reports a
non-terminal status the
loop polls with no delay and spins a core until the job finishes.
`await_completion` and `await_completion_timeout` had the same bug and no
callers. In the
timeout variant `continue` also skipped `time += 100`, so `timeout_ms` was
unreachable.
# What changes are included in this PR?
- `run_with_subscriber`: collapsed the inner `match` into the outer `if let`
so
non-terminal statuses fall through to the sleep.
- Deleted `await_completion` and `await_completion_timeout` (no callers).
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
